Skip to content

update gradle version #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

update gradle version #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d86d194
update gradle version
SelaseKay Jan 16, 2025
7e50a81
update gradle version in build.gradle
SelaseKay Jan 16, 2025
e01f6f7
add namespace
SelaseKay Jan 16, 2025
81bc727
add buildFeatures
SelaseKay Jan 16, 2025
5689f8b
upgrade pub dependencies
SelaseKay Jan 16, 2025
5cafb16
add buildFeatures
SelaseKay Jan 16, 2025
934aa2c
globally set buildConfig to true
SelaseKay Jan 16, 2025
b05774a
update twitter_login version
SelaseKay Jan 16, 2025
90697fb
add subprojects field
SelaseKay Jan 16, 2025
428f1a5
update google-services version
SelaseKay Jan 16, 2025
a2c8c7e
update minSdkVersion
SelaseKay Jan 16, 2025
4e69bcb
update kotlin version
SelaseKay Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/firebase_snippets_app/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,13 @@ apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
namespace = "com.example.firebase_snippets_app"
compileSdkVersion flutter.compileSdkVersion

buildFeatures {
buildConfig true
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Expand All @@ -45,7 +50,7 @@ android {
defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "com.example.firebase_snippets_app"
minSdkVersion 21
minSdkVersion 23
targetSdkVersion flutter.targetSdkVersion
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
Expand Down
18 changes: 15 additions & 3 deletions packages/firebase_snippets_app/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
buildscript {
ext.kotlin_version = '1.7.10'
ext.kotlin_version = '1.9.0'
repositories {
google()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:7.2.0'
classpath 'com.android.tools.build:gradle:8.1.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath 'com.google.gms:google-services:4.3.10'
classpath 'com.google.gms:google-services:4.3.15'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.7.1'

}
Expand All @@ -19,6 +19,18 @@ allprojects {
google()
mavenCentral()
}

subprojects {
afterEvaluate { project ->
if (project.hasProperty('android')) {
project.android {
if (namespace == null) {
namespace project.group
}
}
}
}
}
Comment on lines +23 to +33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added this snippet because the twitter_login package(i.e a dependency of the main project) uses an outdated Android Gradle Plugin (AGP version 4.1.0), which was causing compatibility issues with the main project that uses AGP 8.1.0. Specifically, the error Namespace not specified. Specify a namespace in the module's build file was occurring.

After some investigation, I found that earlier AGP versions (before 8.x.x) derived the namespace from the AndroidManifest.xml file, while AGP 8.x.x and above require the namespace to be explicitly defined in the module's build.gradle file. Since twitter_login is still on AGP 4.1.0, its namespace property in the build.gradle file was being ignored, leading to the error.

To address this, I added the quoted snippet. It ensures that for any subproject using the Android plugin (project.hasProperty('android')), the namespace is dynamically set to the project’s group property if it’s not already defined(or ignored) in the build.gradle file of the module.

Once the twitter_login package updates its AGP version to 8.x.x or later, this workaround will likely no longer be necessary. There's already an active issue requesting for AGP version upgrade: 0maru/twitter_login#140

}

rootProject.buildDir = '../build'
Expand Down
1 change: 1 addition & 0 deletions packages/firebase_snippets_app/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
org.gradle.jvmargs=-Xmx1536M
android.useAndroidX=true
android.enableJetifier=true
android.defaults.buildfeatures.buildconfig=true
2 changes: 1 addition & 1 deletion packages/firebase_snippets_app/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-all.zip
Loading
Loading