Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polling mechanism #14

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add polling mechanism #14

wants to merge 18 commits into from

Conversation

goweiss
Copy link
Collaborator

@goweiss goweiss commented Feb 26, 2024 •
edited
Loading

  • add PollingService class with logic
  • on startup doing a full sync
  • every minute, performs partial sync (up to 48 hours back)
  • polling and webhooks can be activated together (although no reason to enable polling if webhooks are implemented properly)

@goweiss goweiss marked this pull request as ready for review February 26, 2024 13:52
yuval-fireblocks
yuval-fireblocks reviewed Feb 28, 2024
View reviewed changes
@goweiss goweiss self-assigned this Mar 3, 2024
@goweiss goweiss force-pushed the COR-49927-add-polling branch from 904721a to 9ae79a5 Compare April 16, 2024 06:54
@goweiss goweiss force-pushed the COR-49927-add-polling branch from 9ae79a5 to 659197d Compare July 11, 2024 12:52
@goweiss goweiss changed the title COR-49927 add polling mechanism Add polling mechanism Oct 31, 2024
goweiss and others added 18 commits November 17, 2024 17:15
@goweiss
Add main.ts and init function to fix db initialization race condition…
82d5dfb 
… when running e2e tests
@goweiss
code + test
bd6455a
@goweiss
Adding consistency handling when both polling & webhooks defined
bc30872
@goweiss
add fullSync and pagination
2c33f3f
@goweiss
Add transaction created flow: increase polling frequency
52a7ee8
@goweiss
add clearTimeout in 'stop' function
b0adb19
@goweiss
Make pollingService a singleton
f6fb29a
@goweiss
- remove pollAndUpdateAll and combine logic with single function poll…
b7e2d84 
…AndUpdate

- remove now not needed function handleTransactionCreatedOrUpdated
@goweiss
remove code duplication of fetchAllTxs
00e1ee0
@goweiss
spelling typo
7f23149
@goweiss
change order of methods
f2a2713
@goweiss
Move common transaction logic from webhook.service to new transaction…
50dd22f 
…DbHelper.service
@goweiss
symbols renaming
5991422
@goweiss
filter NCW transactions only
a6dbcb5
@goweiss
COR-49927 - add polling
87759ae 
- polling only NCW txs
- polling by tx ids
- on-demand short poller for active txs
- tx created/updated events
@goweiss
change logs
892952c
@goweiss
add warning about using polling
20e775f
@goweiss
fix NFT mock, add log
a880dc1
@goweiss goweiss force-pushed the COR-49927-add-polling branch from d57a72d to a880dc1 Compare November 17, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonFireblocks AlonFireblocks Awaiting requested review from AlonFireblocks

@yuval-fireblocks yuval-fireblocks Awaiting requested review from yuval-fireblocks

@amper-fb amper-fb Awaiting requested review from amper-fb

Assignees

@goweiss goweiss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goweiss @yuval-fireblocks