Revert "fix TestLogAndMetrics" #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d9c0242. Signed-off-by: Swagat Bora <[email protected]>
swagatbora90
force-pushed
the
revert_test_fix
branch
from
e6e2473 to
f7c25d0
Compare
austinvazquez
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d9c0242.
Issue #, if available: The above PR requires more work since latest Firecracker logging configuration has been updated and it no longer produces similar results as v1.4.1. Reverting the above change, since we need to redo the test entirely
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.