flamenco, choreo, app: Integrate Parallel Funk #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
4 times, most recently
from
bcb1b41 to
755548b
Compare
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
6 times, most recently
from
3166238 to
a8bd2e9
Compare
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
from
a8bd2e9 to
a82271b
Compare
jumpsiegel
reviewed
Apr 2, 2025
| if( data ) { | ||
| fd_account_meta_t const * meta = fd_type_pun_const( data ); | ||
| (*ctx->acct_fun)( msg->accts.funk_xid.ul[0], msg->accts.sig, &addr, meta, (uchar*)data + meta->hlen, meta->dlen, ctx->fun_arg ); | ||
| if( datalen >= meta->hlen + meta->dlen ) { |
There was a problem hiding this comment.
What is the thinking about adding this?
jumpsiegel
previously approved these changes
Apr 2, 2025
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
from
4d822fc to
3f5ea72
Compare
topointon-jump
changed the title
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
2 times, most recently
from
abc17a7 to
8d8bb40
Compare
topointon-jump
changed the title
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
2 times, most recently
from
6539b50 to
9b35974
Compare
topointon-jump
force-pushed
the
topointon/funkier-merge
branch
from
9b35974 to
d2f39d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest Funkier integration branch