feat(shred,repair): shred publish to repair #4561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
from
571c579 to
f862fcc
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
2 times, most recently
from
4fe2d68 to
7b30357
Compare
lidatong
changed the title
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
from
7b30357 to
d37682d
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
14 times, most recently
from
ce3676a to
2e8a20a
Compare
KVolodin
reviewed
Mar 20, 2025
src/disco/fd_disco_base.h
Outdated
| ulong completes_ul = (ulong)completes; | ||
| return slot_ul << 32 | shred_idx_ul << 17 | fec_set_idx_ul << 2 | is_code_ul << 1 | completes_ul; | ||
| fd_disco_shred_repair_sig( int type, int is_code_or_data_completes, ulong slot, uint fec_set_idx, uint shred_idx_or_data_cnt_or_parent_off ) { | ||
| ulong type_ul = (ulong)type; |
There was a problem hiding this comment.
To prevent unexpected behavior, ensure that 'type' is either FD_DISCO_SHRED_REPAIR_SIG_TYPE_HDR or FD_DISCO_SHRED_REPAIR_SIG_TYPE_FEC.
assert(type == FD_DISCO_SHRED_REPAIR_SIG_TYPE_HDR || type == FD_DISCO_SHRED_REPAIR_SIG_TYPE_FEC);
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
3 times, most recently
from
0d78ad1 to
5e38532
Compare
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
8 times, most recently
from
c54bba5 to
4ee1fba
Compare
lidatong
force-pushed
the
chali/feat/shred-repair-sig
branch
from
4ee1fba to
8e0a1f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the shred tile and topo such that shred now publishes to repair (Firedancer-only). The idea is the repair tile will now fan-in the shred tiles, and will be a single tile. It will handle merkle chaining validation (which requires serial ordering). It will also know how to repair late shreds inside in-progress FECs, and do this intelligently (only repair shreds in a FEC set that aren't redundant with what's already been received). Finally, repair will also receive and recover duplicate block issues, subsuming / removing the need for the separate eqvoc tile.
The shred_repair sig is now encoded as two different types (shred header or FEC set complete). Previously this was encoded in a single bit on a common message type.
Now the shred tile publishes different message types indicated in the sig. It only publishes to the link if it exists, and only writes to the blockstore if it exists. This simplifies the logic in the shred tile publishing.
Closes #4528