flamenco: refactor txn_ctx/instr_ctx account getters API #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cali-jumptrading
changed the title
cali-jumptrading
changed the title
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
10 times, most recently
from
a114adf to
5b3ca09
Compare
cali-jumptrading
changed the title
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
10 times, most recently
from
7d588cd to
cea7474
Compare
cali-jumptrading
requested review from
ibhatt-jumptrading,
topointon-jump and
jumpsiegel
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
2 times, most recently
from
c7c10f6 to
f9b677f
Compare
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
5 times, most recently
from
cbe19cb to
11274c7
Compare
jumpsiegel
previously approved these changes
Mar 26, 2025
mjain-jump
reviewed
Mar 26, 2025
mjain-jump
reviewed
Mar 26, 2025
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
6 times, most recently
from
86a80a7 to
875c33b
Compare
|
|
||
| if ( FD_UNLIKELY( use_sysvar_instructions ) ) { | ||
| ret = fd_sysvar_instructions_update_current_instr_idx( txn_ctx, i ); | ||
| if( ret != FD_ACC_MGR_SUCCESS ) { | ||
| FD_LOG_WARNING(( "sysvar instructions failed to update instruction index" )); | ||
| txn_ctx->instr_err_idx = i; |
There was a problem hiding this comment.
This was to prevent a segfault when debugging a mismatch in test-vectors.
| fd_exec_txn_ctx_get_account_modify_fee_payer( fd_exec_txn_ctx_t * ctx, | ||
| fd_txn_account_t * * account ); | ||
| static inline int | ||
| fd_exec_txn_ctx_find_index_of_account( fd_exec_txn_ctx_t const * ctx, |
There was a problem hiding this comment.
Is there a reason we do a reverse iteration here?
There was a problem hiding this comment.
I suspect it's for performance reasons to compare to 0 instead of N. The slight performance edge probably is negligible, so I'm happy to change to forward iteration if it's clearer.
ibhatt-jumptrading
previously approved these changes
Mar 28, 2025
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
from
875c33b to
fd24d11
Compare
cali-jumptrading
force-pushed
the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
from
fd24d11 to
7e99720
Compare
ibhatt-jumptrading
approved these changes
Mar 28, 2025
cali-jumptrading
deleted the
cali/clean-up-txn-ctx-borrowed-accounts-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
try_borrow_last_program_accountin the instr_ctx to match agave semantics and account borrowing checks.