Skip to content

flamenco: optimisations to the types fuzzer #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

flamenco: optimisations to the types fuzzer #4634

merged 1 commit into from
Mar 31, 2025

Conversation

anarcheuz
Copy link
Collaborator

No description provided.

@anarcheuz anarcheuz force-pushed the type_fuzzer branch 3 times, most recently from be9f00b to 117531f Compare March 25, 2025 21:26
topointon-jump
topointon-jump previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make this run with deep-asan in a follow-up PR?

ripatel-fd
ripatel-fd previously requested changes Mar 25, 2025
View reviewed changes
@ripatel-fd
Copy link
Contributor

@anarcheuz Thanks for the nice fuzzer improvement. The formatting could use some work. CONTRIBUTING.md has a couple examples how we format code. Unfortunately, we don't have an auto formatter. If you want, I can do the formatting pass for you.

@anarcheuz
Copy link
Collaborator Author

@ripatel-fd Much appreciated! I think I got most of the things right. Please take another look.

@anarcheuz anarcheuz force-pushed the type_fuzzer branch 2 times, most recently from 9e9c639 to 21ebac5 Compare March 25, 2025 23:38
topointon-jump
topointon-jump previously approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if @ripatel-fd is ok with it :D

@ripatel-fd
Copy link
Contributor

Not blocking this change @topointon-jump. However, @anarcheuz doesn't have merge rights, so you'll have to merge.

@ripatel-fd ripatel-fd dismissed their stale review March 31, 2025 14:56

This change is messy, but I intend to rewrite it later

@topointon-jump topointon-jump added this pull request to the merge queue Mar 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2025
@topointon-jump topointon-jump added this pull request to the merge queue Mar 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2025
@anarcheuz anarcheuz force-pushed the type_fuzzer branch 2 times, most recently from fc87fcb to 6dd9b53 Compare March 31, 2025 15:50
@anarcheuz
Copy link
Collaborator Author

I've rebased.

@ibhatt-jumptrading ibhatt-jumptrading added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 314c3fa Mar 31, 2025
11 checks passed
@ibhatt-jumptrading ibhatt-jumptrading deleted the type_fuzzer branch March 31, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibhatt-jumptrading ibhatt-jumptrading ibhatt-jumptrading approved these changes

@topointon-jump topointon-jump topointon-jump left review comments

@ripatel-fd ripatel-fd Awaiting requested review from ripatel-fd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anarcheuz @ripatel-fd @ibhatt-jumptrading @topointon-jump