jsiegel/spad_chk: add in better handholding and a fd_spad_alloc_check#4652
Closed
jumpsiegel wants to merge 1 commit intomainfrom
Closed
jsiegel/spad_chk: add in better handholding and a fd_spad_alloc_check#4652jumpsiegel wants to merge 1 commit intomainfrom
jumpsiegel wants to merge 1 commit intomainfrom
Conversation
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
2 times, most recently
from
25215f5 to
ea3b4cb
Compare
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
from
3ccc6df to
b81ef45
Compare
Contributor
ibhatt-jumptrading
left a comment
ibhatt-jumptrading
left a comment
There was a problem hiding this comment.
Didn't look at the util changes, but this looks good. Does this work with the new exec changes too? Looks good otherwise
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
from
b81ef45 to
a2b8136
Compare
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
2 times, most recently
from
1d3be01 to
e271302
Compare
topointon-jump
previously approved these changes
Apr 1, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
2 times, most recently
from
5caa2f6 to
6a7a4a7
Compare
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
2 times, most recently
from
cc04d32 to
668cd3c
Compare
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
7 times, most recently
from
dd25975 to
ca714c9
Compare
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
from
b7b7552 to
bc05137
Compare
jumpsiegel
force-pushed
the
jsiegel/spad_chk
branch
from
6fdfd60 to
b384eca
Compare
ripatel-fd
reviewed
May 11, 2025
Comment on lines
+444
to
+447
| static inline void * | ||
| fd_spad_alloc_check( fd_spad_t * spad, | ||
| ulong align, | ||
| ulong sz ); |
Contributor
There was a problem hiding this comment.
Suggested change
| static inline void * | |
| fd_spad_alloc_check( fd_spad_t * spad, | |
| ulong align, | |
| ulong sz ); | |
| void * | |
| fd_spad_alloc_check( fd_spad_t * spad, | |
| ulong align, | |
| ulong sz ); |
The method body in this function is in fd_spad.c
Contributor
|
@jumpsiegel Looks good. Could you rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.