blockstore: check that shred_max is power of two #4683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvarela-jump
requested changes
Apr 25, 2025
nit, but it is easy to imagine an operator putting in a value that is not a power of two, which would lead to fd_buf_shred_map_footprint being 0.
two-heart
force-pushed
the
shred-max-check
branch
from
1a00877 to
88f6d61
Compare
jvarela-jump
approved these changes
Apr 28, 2025
jvarela-jump
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nit, but it is easy to imagine an operator putting in a value that is not a power of two, which would lead to fd_buf_shred_map_footprint being 0. We want a meaningful error message in this case.