poh, pack: adjust cost limits dynamically#4702
Merged
jherrera-jump merged 1 commit intomainfrom Apr 14, 2025
Merged
Conversation
jherrera-jump
force-pushed
the
jherrera/fix-max-cus
branch
7 times, most recently
from
e684b2b to
11c357f
Compare
mmcgee-jump
reviewed
Apr 3, 2025
| <summary>The number of compute units rebated for each block pack produced. Compute units are rebated when a transaction fails prior to execution or requests more compute units than it uses.</summary> | ||
| </histogram> | ||
| <histogram name="CusNet" min="1000000" max="48000000"> | ||
| <histogram name="CusNet" min="1000000" max="60000000"> |
Contributor
There was a problem hiding this comment.
Hmm. This histogram doesn't really make much sense, if CUs changes dynamically. Maybe we should make this CUSPct which is % filled.
Contributor
Author
There was a problem hiding this comment.
let me know if you think we should also remove the old metric, I've kept it in for now
jherrera-jump
force-pushed
the
jherrera/fix-max-cus
branch
4 times, most recently
from
b35643c to
e6c10fe
Compare
jherrera-jump
force-pushed
the
jherrera/fix-max-cus
branch
from
e6c10fe to
be226c5
Compare
jherrera-jump
force-pushed
the
jherrera/fix-max-cus
branch
7 times, most recently
from
cc86bda to
c503798
Compare
ptaffet-jump
previously approved these changes
Apr 13, 2025
Contributor
ptaffet-jump
left a comment
ptaffet-jump
left a comment
There was a problem hiding this comment.
A few nits, but looks good otherwise. Thanks!
jherrera-jump
force-pushed
the
jherrera/fix-max-cus
branch
2 times, most recently
from
531eaba to
1cbe1f3
Compare
jherrera-jump
force-pushed
the
jherrera/fix-max-cus
branch
from
1cbe1f3 to
041924b
Compare
ptaffet-jump
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4691
agave diff