fix(seccomp): remove trailing colon in readlink policy to allow readlink calls #4739
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fd_batch_tile.seccomppolicy, the readlink: entry is incorrectly configured with a trailing colon and no follow-up expression. This causes generate_filters.py to treat the line as having an empty expression, ultimately denying readlink system calls rather than allowing them.
As a result, any function—such as produce_snapshot—that relies on readlink("/proc/self/fd/...") will fail, causing the snapshot process to abort with a “Failed to readlink the snapshot file” error.