fix(seccomp): remove the narrower read rule to keep the broader intent #4744
+37
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fd_rpcserv_tile.seccomppolicy, two separate read rules were defined: 1) A broader rule allowing reads from any FD except 2, logfile_fd, and rpcserv_socket_fd. 2) A narrower rule only allowing reads from blockstore_fd. Because generate_filters.py overwrites earlier rules with later ones, the second (narrower) rule effectively replaced the first, resulting in read calls from all other FDs being denied. To maintain the original intended security boundary, this commit removes the second rule, ensuring the broader rule remains in effect.
mmcgee-jump
reviewed
Apr 10, 2025
| @@ -68,8 +68,5 @@ close: (not (or (eq (arg 0) 2) | |||
| # arg 2 is the timeout. | |||
| poll: (eq (arg 2) 0) | |||
|
|
|||
| # blockstore: read archival file | |||
There was a problem hiding this comment.
Don't you need to add blockstore_fd to the above read rule as well then?
There was a problem hiding this comment.
If blockstore_fd is not one of the three disallowed file descriptors, then it’s already implicitly allowed by the first rule. In that case, you can simply keep the first rule.
see #4740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as PR #4742, but also checking in the changes to the generated code.