[codex] Update vendored Spark Name registration format#1
Open
reubenyap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sparkmobileSpark Name transaction data struct to v2 registration format.operationTypebyte, defaulting to registration (0).Why
Stack Wallet consumes Spark Name registration through this Flutter wrapper. The native Spark Name registration payload changed upstream, so the vendored copy needs the same minimal registration-format update.
Related
Review notes
No new Dart or FFI API is added. Stack builds the fee-output script itself; this wrapper change only updates the serialized Spark Name payload.
Validation
git diff --checkpasses locally, with only Windows CRLF warnings.codex-build/windows/shared/libflutter_libsparkmobile.dll.-DCMAKE_CXX_FLAGS=-fpermissiveafter strict GCC 16 stopped in existing vendored secp256k1 extern/static declarations. No repository build flags were changed.