Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input now has the value of query parameter in dataset search page #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

A-Souhei
Copy link
Contributor

@A-Souhei A-Souhei commented Feb 3, 2025

Description

The search parameter is now set as value of the search input

image

Closes https://github.com/fjelltopp/who-afro-ckan/issues/617

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The GitHub ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@A-Souhei A-Souhei self-assigned this Feb 3, 2025
@A-Souhei A-Souhei added the enhancement New feature or request label Feb 3, 2025
@A-Souhei A-Souhei marked this pull request as ready for review February 3, 2025 08:54
@A-Souhei A-Souhei added the minor label Feb 3, 2025
Copy link
Member

@jonathansberry jonathansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that this solution fixes the indicators page as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants