[feature] Add 2 DAG Algorithms: ancestors and descendants #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydrosquall
force-pushed
the
feature/add-dag-ancestors-descendants
branch
from
075480f to
4b39f2c
Compare
hydrosquall
changed the title
hydrosquall
force-pushed
the
feature/add-dag-ancestors-descendants
branch
from
4779c75 to
533739a
Compare
hydrosquall
force-pushed
the
feature/add-dag-ancestors-descendants
branch
from
533739a to
fc14124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the docs to find some algorithms for processing DAGs, and noticed these two were missing / marked as TODO. They're nearly identical ports of the Python algorithm, the only difference is a different syntax for working with Sets.
https://networkx.github.io/documentation/stable/_modules/networkx/algorithms/dag.html#descendants
Let me know if you'd like to see anything else before these get brought into the mainline branch.
Checklist