Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lodash from 3.3.1 to 4.17.21 #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Joshnovski
Copy link

Modified entry point to align with the package name. Installing jsnetworkx places the entry point in node_modules/jsnetworkx/jsnetworkx.js. As a result, I changed "main": "node/index.js" to "main": "jsnetworkx.js" in package.json.

I also updated the Lodash dependency to 4.17.21 as Lodash versions before 4.17.21 are vulnerable to Command Injection via the template function.

Potential issues

When I imported the package into my react component via;

import * as jsnx from "jsnetworkx";

And hover over "jsnetworkx" There is a warning message which may or may not be problematic;

"Could not find a declaration file for module 'jsnetworkx'. 'c:/Users/joshm/Desktop/Coding/CS50W/Final Project/AlgorithmVisualizer/frontend/node_modules/jsnetworkx/jsnetworkx.js' implicitly has an 'any' type.
Try npm i --save-dev @types/jsnetworkx if it exists or add a new declaration (.d.ts) file containing declare module 'jsnetworkx';ts(7016)"

Even with this occurring, I am having zero problems so far with the updated version.

Here is an image of my projects import to node_modules for reference;

node_modules

@Joshnovski Joshnovski changed the title Update lodash Bump lodash from 3.3.1 to 4.17.21 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant