Trigger binary and docker builds in release flow#558
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release automation so that when release tags (including RC tags) are created via workflows, the main [op-rbuilder] Release workflow is explicitly dispatched to perform binary and Docker builds (which otherwise may not run due to GitHub’s workflow-chaining restrictions when using GITHUB_TOKEN).
Changes:
- Add
gh workflow rundispatch from the release-plz flow after releases are created. - Add
gh workflow rundispatch from the release-candidate tag flow after pushing the RC tag. - Expand workflow permissions to allow triggering other workflows (
actions: write).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/release-plz.yaml |
Adds a post-release dispatch step to run the main release workflow for each created tag, and broadens permissions to allow workflow dispatch. |
.github/workflows/op_rbuilder_release_candidate.yaml |
After creating/pushing an RC tag, dispatches the main release workflow so binary and Docker builds run for RCs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
16
| permissions: | ||
| pull-requests: write | ||
| contents: write | ||
| actions: write | ||
|
|
||
| jobs: |
Comment on lines
+46
to
+54
| run: | | ||
| jq -r '.[].tag' <<< "$RELEASES" | while read -r tag; do | ||
| echo "Dispatching release workflow for ${tag}" | ||
| gh workflow run op_rbuilder_release.yaml \ | ||
| --ref "${tag}" \ | ||
| -f build-binary=true \ | ||
| -f build-docker=true \ | ||
| -f draft-release=true | ||
| done |
Comment on lines
+58
to
+67
| - name: Trigger release workflow | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| echo "Dispatching release workflow for ${TAG}" | ||
| gh workflow run op_rbuilder_release.yaml \ | ||
| --ref "${TAG}" \ | ||
| -f build-binary=true \ | ||
| -f build-docker=true \ | ||
| -f draft-release=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Trigger docker publish in the new release flow
💡 Motivation and Context
release candidates and tags were pushed but not docker builds
✅ I have completed the following steps:
make lintmake test