fix: pin FLASHBLOCKS env var names to preserve backward compatibility#485
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
avalonche
force-pushed
the
fix/flashblocks-env-var
branch
from
1425e4e to
0bdaf1b
Compare
julio4
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
FLASHBLOCKS=trueas the env var that enables the flashblocks WebSocket client, and defensively pin every otherFLASHBLOCKS*env name so a future field rename cannot silently break the public env contract again.Motivation
#373 renamed the field
FlashblocksArgs::flashblocks→FlashblocksWsArgs::flashblocks_wsand addedid = "flashblocks_ws". clap derives the env-var name fromidwhenenvis left bare, so the public env var silently changed fromFLASHBLOCKStoFLASHBLOCKS_WS. The CLI flag (--flashblocks) was preserved via explicitlong = "flashblocks"but the env path was missed.