Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reenable QRDBIO plugin and update rdblib to 2.4.5 #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reenable QRDBIO plugin and update rdblib to 2.4.5 #112

wants to merge 1 commit into from

Conversation

NeroBurner
Copy link
Contributor

With commit 6da29e4 the QRDBIO plugin was disabled/removed.

Reenable it again and update the dependency rdblib to its latest version v2.4.5

As a note: RDB files created with older versions of rdblib are readable by a newer version of rdblib (backwards compatibility).

@flathubbot
Copy link
Contributor

Started test build 155295

@flathubbot
Copy link
Contributor

Build 155295 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/138382/org.cloudcompare.CloudCompare.flatpakref

@rjanvier
Copy link
Collaborator

I think rdblib is not a free software it's why it's not part of the distribution anymore. Maybe it could be an extension, what do you think?

@NeroBurner
Copy link
Contributor Author

oh I thought it was accidentally removed. Could you link me to the reasoning why it was removed?

This is the only flatpak I've ever contributed to, so I'm a bit out of my depth here. Would an extension mean I need to create a separate flathup package + github project to build that extension, or could the extension definition be part of this repo (as described in section Bundled extensions)?

@rjanvier
Copy link
Collaborator

Even if I acknowledge it's very nice to have a cross platform TLS vendor SDK (I think RIEGL is the only manufacturer to do this, so thank you !), It was removed because I'm not confortable in advertising CC is GPL and shipping it with a binary blob and I think it could matter for some Linux user. If you want I could try to set up the extension, I have a bunch of maintenance work planned for this package in the short term.

@NeroBurner
Copy link
Contributor Author

That's very sound reasoning. Thanks for explaining it to me.

Yes please. That would be extremely helpful. Thank you 🙇‍♂️

@flathubbot
Copy link
Contributor

Started test build 171683

@christian-rauch
Copy link
Collaborator

What is the status of this? Are we going to include rdblib (merge this PR) or not (close this PR)?

@flathubbot
Copy link
Contributor

Build 171683 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/154788/org.cloudcompare.CloudCompare.flatpakref

@riegl-gc @christian-rauch
reenable QRDBIO plugin and update rdblib to 2.4.5
1d5b166 
With commit 6da29e4 the QRDBIO plugin
was disabled/removed.

Reenable it again and update the dependency `rdblib` to its latest
version `v2.4.5`

As a note: RDB files created with older versions of rdblib are readable by
a newer version of rdblib (backwards compatibility).
@flathubbot
Copy link
Contributor

Started test build 181240

@flathubbot
Copy link
Contributor

Build 181240 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/164405/org.cloudcompare.CloudCompare.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NeroBurner @flathubbot @rjanvier @christian-rauch @riegl-gc