Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Remove EOL notice #10

Closed
wants to merge 2 commits into from
Closed

Remove EOL notice #10

wants to merge 2 commits into from

Conversation

Newbytee
Copy link
Collaborator

We have new maintainers.

We have new maintainers.
@flathubbot
Copy link

Started test build 78019

@flathubbot
Copy link

Build 78019 failed

Grumbel removed his fork of shared-modules, so it's just a 404 now.
@flathubbot
Copy link

Started test build 78021

@flathubbot
Copy link

Build 78021 failed

@Newbytee Newbytee mentioned this pull request Oct 31, 2023
@AsciiWolf
Copy link
Collaborator

bot, build

@flathubbot
Copy link

Queued test build for org.seul.pingus.

@flathubbot
Copy link

Started test build 78033

@flathubbot
Copy link

Build 78033 failed

@@ -14,7 +14,17 @@
"--socket=pulseaudio"
],
"modules": [
"shared-modules/sigc++/sigc++-2.0.json",
{
"name": "libsigc++-2.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably update the other modules (including shared-modules) as well as a part of this PR.

@Newbytee
Copy link
Collaborator Author

bot, build

It's not going to work because Grumbel removed a bunch of repositories that building this depends on. We can fix it, but it needs work.

@flathubbot
Copy link

Queued test build for org.seul.pingus.

@AsciiWolf
Copy link
Collaborator

It's not going to work because Grumbel removed a bunch of repositories that building this depends on. We can fix it, but it needs work.

Oops! I did not notice.

@Newbytee
Copy link
Collaborator Author

Newbytee commented Oct 31, 2023

Oh, come on bot. Anyway, I suggest you look at #6

@flathubbot
Copy link

Started test build 78034

@flathubbot
Copy link

Build 78034 failed

@AsciiWolf
Copy link
Collaborator

AsciiWolf commented Oct 31, 2023

It looks like that Pingus is now on GitHub and the AppData file got removed, probably because the maintainer erroneously thinks that it is relevant only to Flatpaks. I pointed out to them that they are not correct, but they ignored my ticket.

edit: I have made a new ticket on GitHub about the AppData file removal.

@AsciiWolf
Copy link
Collaborator

@Newbytee Change the Pingus GitLab repo url to a GitHub one: https://github.com/Pingus/pingus.git

Keep the same Git commit (so we don't have to deal with the removed AppData file for now), just change the repo.

@AsciiWolf
Copy link
Collaborator

AsciiWolf commented Nov 1, 2023

Also, I think that maybe we could merge this PR with #6 to make things easier.

/cc @Newbytee @JakobDev

We need to:

  • Remove the EOL notice.
  • Change the Pingus repo url to GitHub one.
  • Switch from using shared-modules that no longer exist (sadly all of them) to regular modules.
  • Update all modules.
  • Update the runtime used by this Flatpak to 23.08.

In the future, we will also have to ship the AppStream metadata file with the Flatpak since upstream removed their AppData file. For now, we can stick with the original commit (25d7f3ffbb6ed31de5da7b8da8f9c5fdef75b4f0) instead of bumping it or we can use the commit from before the AppData file removal (2131a2b18325a15eafc0ddd811447a1741e07ac4).

@AsciiWolf
Copy link
Collaborator

Replaced by #11.

@AsciiWolf AsciiWolf closed this Nov 1, 2023
@AsciiWolf AsciiWolf deleted the pingus-no-eol branch November 1, 2023 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants