-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
We have new maintainers.
Started test build 78019 |
Build 78019 failed |
Grumbel removed his fork of shared-modules, so it's just a 404 now.
Started test build 78021 |
Build 78021 failed |
bot, build |
Queued test build for org.seul.pingus. |
Started test build 78033 |
Build 78033 failed |
@@ -14,7 +14,17 @@ | |||
"--socket=pulseaudio" | |||
], | |||
"modules": [ | |||
"shared-modules/sigc++/sigc++-2.0.json", | |||
{ | |||
"name": "libsigc++-2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably update the other modules (including shared-modules) as well as a part of this PR.
It's not going to work because Grumbel removed a bunch of repositories that building this depends on. We can fix it, but it needs work. |
Queued test build for org.seul.pingus. |
Oops! I did not notice. |
Oh, come on bot. Anyway, I suggest you look at #6 |
Started test build 78034 |
Build 78034 failed |
It looks like that Pingus is now on GitHub and the AppData file got removed, probably because the maintainer erroneously thinks that it is relevant only to Flatpaks. I pointed out to them that they are not correct, but they ignored my ticket. edit: I have made a new ticket on GitHub about the AppData file removal. |
@Newbytee Change the Pingus GitLab repo url to a GitHub one: https://github.com/Pingus/pingus.git Keep the same Git commit (so we don't have to deal with the removed AppData file for now), just change the repo. |
Also, I think that maybe we could merge this PR with #6 to make things easier. We need to:
In the future, we will also have to ship the AppStream metadata file with the Flatpak since upstream removed their AppData file. For now, we can stick with the original commit (25d7f3ffbb6ed31de5da7b8da8f9c5fdef75b4f0) instead of bumping it or we can use the commit from before the AppData file removal (2131a2b18325a15eafc0ddd811447a1741e07ac4). |
Replaced by #11. |
We have new maintainers.