-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched from metadata_url to metadata for end user authentication #26042
base: main
Are you sure you want to change the base?
Conversation
…b.com/fleetdm/fleet into allenhouchins-end-user-metadata-field
Maybe $DOGFOOD_SSO_METADATA has newlines, which messes things up |
@getvictor The odd thing about this is that same exact variable works without issue further down in the yaml. The error also mentions JSON but the data inside that variable is XML. |
@allenhouchins agreed. I think we should get some engineering help digging in. Can you please file a bug for this? |
@noahtalerman |
Keeping this pull request open while this bug is being looked at: #26135 |
it-and-security/default.yml
Outdated
metadata_url: $DOGFOOD_MDM_SSO_METADATA_URL | ||
issuer_uri: $DOGFOOD_SSO_ISSUER_URI | ||
metadata: |- | ||
$DOGFOOD_SSO_METADATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allenhouchins based on my testing for #26135 I would experiment with moving this two spaces forward or two spaces back, i.e.
metadata: |-
$DOGFOOD_SSO_METADATA
or
metadata: |-
$DOGFOOD_SSO_METADATA
and see if either of those works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgress454 No change in behavior.
Two spaces forward: 2927aa3
Two spaces backward: c1bc859
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for trying
@allenhouchins so based on everything I'm seeing, this is gonna require a new secret. The indentation in the current one won't work for |
Switched from metadata_url to metadata for end user authentication.