Fleet UI: Fix policy software automation fail to report as failing

[RachelElysia]

Issue

For #25637

Description

• concat was not modifying the original response array, errors were not actually being thrown to the try catch
• await Promise.all(responses); will actually wait for all the API calls to complete and will throw an error if any of them fail

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
• A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
• Manual QA for all new/changed functionality

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (df8e753) to head (b755cbc).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #26044   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files        1631     1631           
  Lines      156293   156293           
  Branches     4088     4088           
=======================================
  Hits        99471    99471           
  Misses      48984    48984           
  Partials     7838     7838           

Flag	Coverage Δ
frontend	53.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RachelElysia]

hey @jacobshandling any chance you can take a minute today to review this? ☀️

[jacobshandling]

Aha, concat doesn't mutate the array itself!

[jacobshandling]

Would directly assigning responses like this also do the trick?

      const responses = changedPolicies.map((changedPolicy) => {
        return teamPoliciesAPI.update(changedPolicy.id, {
          // "software_title_id": null will unset software install for the policy
          // "software_title_id": X will set the value to the given integer (except 0).
          software_title_id: changedPolicy.swIdToInstall || null,
          team_id: teamIdForApi,
        });
      });

[jacobshandling]

Did you confirm that one error doesn't prevent the rest of the calls from being cancelled?

[jacobshandling]

It'd be nice to avoid combining try..catch... and .catch syntax if possible, is there a way to do this with just try/catch?