Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Learn more link for cert key error when turning on windows mdm #26170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Feb 7, 2025

For #26047

adds a "learn more" link on the cert/key pair error when turning on windows.

image

This also updates the CustomLink to add new variant for when we want to display this in a flash message

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Manual QA for all new/changed functionality

@ghernandez345 ghernandez345 requested a review from a team as a code owner February 7, 2025 15:30
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.63%. Comparing base (329c454) to head (867f0e5).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
frontend/components/CustomLink/CustomLink.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #26170   +/-   ##
=======================================
  Coverage   63.63%   63.63%           
=======================================
  Files        1631     1631           
  Lines      156363   156359    -4     
  Branches     4045     4090   +45     
=======================================
  Hits        99505    99505           
+ Misses      49017    49012    -5     
- Partials     7841     7842    +1     
Flag Coverage Δ
frontend 53.50% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghernandez345 ghernandez345 force-pushed the fix-ui-missing-learn-more-link-windows-mdm branch from add218b to 9cb3b15 Compare February 7, 2025 16:00
sgress454
sgress454 previously approved these changes Feb 12, 2025
Copy link
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍 , code LGTM. I'd say we should link directly to the part of the guide that's specific to setting up certs, but it's the very first part anyway.

@ghernandez345
Copy link
Contributor Author

Tested 👍 , code LGTM. I'd say we should link directly to the part of the guide that's specific to setting up certs, but it's the very first part anyway.

@sgress454 sounds good. made this change. Can i get a rereview?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants