-
Notifications
You must be signed in to change notification settings - Fork 9
Modular meshing and Snappy #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
piotrkluba
wants to merge
60
commits into
develop
Choose a base branch
from
snappy-main
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 46 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
074e5a6
general snappy framework, does not work
piotrkluba a95f5e7
basic translator functionality
piotrkluba 712b515
tests repaired
piotrkluba 5717d7a
reversed unnecessary changes
piotrkluba 2465712
reversed unnecessary changes again
piotrkluba be7d991
reversed unnecessary changes yet again
piotrkluba c6e41e0
points in mesh added
piotrkluba 9893ea2
added strictRegionSnap
piotrkluba bf593c9
implemented initial validators
piotrkluba 757ed1f
corrected errors with validators and included angle
piotrkluba 4499e0f
always include strictFeatureSnap
piotrkluba 645adbf
pulled snappy clases to main namespace
piotrkluba 5ecbaed
repaired handlin volume meshing params and empty edge lists
piotrkluba 8c44b58
fixed volume meshing in modular workflow
piotrkluba 253e538
fixed Self import error
piotrkluba 7687b49
added a test
piotrkluba b531409
fixes to translator
piotrkluba bb6d9ae
fixed empty regions and bodies n edge refinement
piotrkluba 1e5d3bf
additional fixe with more tests coverage
piotrkluba 3f44994
draft change
piotrkluba e4a8953
fixed turning off edges at smoothing
piotrkluba 3c1af03
added validators to quality metrics
piotrkluba b8db661
added more validators
piotrkluba 9600a3b
Use original edges for smoothing - snappy (#1304)
piotrkluba 89673f2
Added UniformRefinement to snappy (#1331)
piotrkluba f75697b
Merge rc/25.6 to snappy main branch (#1347)
piotrkluba 4bc6ee1
bumped version for beta publish
maciej-flexcompute 54fa8bc
Squashed commit of the following:
piotrkluba ebc9e18
merge addition
piotrkluba b3b6911
merging kinks repaired
piotrkluba a09705a
Revert "Ensure the geometry tolerance and the planar tolerance are co…
benflexcompute ddca991
Skip boundaries during translation if the boundary is not found in vo…
benflexcompute 100e1bb
validation context extracts also from ModularMeshingWorkflow
piotrkluba b3d86ef
validation of volume zones corrected for different meshing shemes
piotrkluba 34ecc84
bump version to 25.8.0b2, formatter changes
piotrkluba a159f21
fixed planar_face_tolerance context bug
piotrkluba c375ce8
Python meshing refactor (#1415)
piotrkluba 4ea8698
user defined farfield no longer required when using custom volume or …
piotrkluba 81cf82a
Rebased snappy to main (#1449)
piotrkluba 7eca1e1
revert fix of translating missing boundaries as it was done in main
piotrkluba 7aa255d
Merge branch 'develop' into snappy-main
piotrkluba abe9e77
formatter
piotrkluba b53f2dd
unnecessary warnings removed
piotrkluba e87dffd
added SeedpointZone to rotation
piotrkluba 2f6b5e0
formatter
piotrkluba 957a663
Renaming on _get_boundary_full_name
benflexcompute 517624d
Some renaming
benflexcompute f32de54
changed type to type_name as a discriminator in added types
piotrkluba 6302aee
Merge branch 'snappy-main' of github.com:flexcompute/Flow360 into sna…
piotrkluba 85c576d
farfield cosmetic changes
piotrkluba cf9a46f
revertet some weird change to base model
piotrkluba 0c8c532
Rebase to newest develop (#1485)
piotrkluba 735cf9f
Added the base_spacing parameter to control snappy octree (#1495)
piotrkluba de73fbe
exposed octree spacing
piotrkluba 9976667
inverted the spacing convention
piotrkluba 9ae168c
changed warning formatting
piotrkluba 9369ca0
add condition for SnappySurfaceEdgeRefinement validation
piotrkluba 587165c
removed the optional annotation from boundary first layer thickness
piotrkluba 6dfde38
Fix spacings not being translated in list (#1500)
piotrkluba d3ae923
Two level structure for geometry referencing snappy (#1465)
piotrkluba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_preprocess_nested_list
returns a list, ifvalue
is a tuple then we are changing the data type by assigning a list back to it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not remember altering that, I changed that back to its brevious form and tests passed, I hope it does not break things, but then i do not thing changing tuple into list would necessairly have any consequences