Added gap sealing #1497
Open
Added gap sealing #1497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| healing_gap_size: Optional[LengthType.NonNegative] = pd.Field( | ||
| 0.0 * u.m, | ||
| description="FFlag that defines the threshold size below which all geometry gaps are automatically closed..", |
There was a problem hiding this comment.
"Threshold size below which all geometry gaps are automatically closed. Zero is deactivated."
There was a problem hiding this comment.
We need to decide if we're going to call this feature gap healing or gap sealing. I prefer the latter since it will seal physical gaps, even if the input geometry is completely clean and there's nothing to heal.
|
|
||
| healing_gap_size: Optional[LengthType.NonNegative] = pd.Field( | ||
| 0.0 * u.m, | ||
| description="FFlag that defines the threshold size below which all geometry gaps are automatically closed..", |
mikeparkflex
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.