Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ruff tests since last check #1707

Merged
merged 1 commit into from
May 24, 2024
Merged

fix ruff tests since last check #1707

merged 1 commit into from
May 24, 2024

Conversation

tylerflex
Copy link
Collaborator

since #1681

@tylerflex tylerflex requested a review from yaugenst-flex May 15, 2024 21:14
@tylerflex tylerflex force-pushed the tyler/fix/ruff_tests branch from be8e8a1 to 3bb54b2 Compare May 15, 2024 21:31
@tylerflex tylerflex added the 2.7 will go into version 2.7.* label May 15, 2024
@tylerflex tylerflex force-pushed the tyler/fix/ruff_tests branch from 3bb54b2 to fef8d52 Compare May 15, 2024 21:41
yaugenst-flex
yaugenst-flex reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks. Guess the only question is whether things that are not used should be assigned at all. I went with no assignment in my last fixes, here it's _ =.

@tylerflex tylerflex mentioned this pull request May 24, 2024
Merged
@tylerflex tylerflex force-pushed the tyler/fix/ruff_tests branch from fef8d52 to c0cad1f Compare May 24, 2024 16:27
@tylerflex tylerflex merged commit c528295 into pre/2.7 May 24, 2024
16 checks passed
@tylerflex tylerflex deleted the tyler/fix/ruff_tests branch May 24, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaugenst-flex yaugenst-flex yaugenst-flex left review comments

Assignees
No one assigned
Labels
2.7 will go into version 2.7.*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerflex @yaugenst-flex