Skip to content

Conversation

dmarek-flex
Copy link
Contributor

@dmarek-flex dmarek-flex commented Oct 15, 2025

Note sure if this affected anyone else, but I was getting duplicate ruff checks in the pre-commit hook.

Greptile Overview

Updated On: 2025-10-15 20:53:26 UTC

Greptile Summary

This PR fixes a pre-commit configuration issue causing duplicate ruff checks. The change adds explicit stages: [pre-commit] configuration to both the ruff-check and ruff-format hooks in the .pre-commit-config.yaml file. Previously, these hooks were running at multiple git hook stages (pre-commit and commit-msg) because the default install hook types include both stages. This duplication was creating an inefficient workflow where the same linting and formatting operations were executed twice. The fix ensures ruff only runs during the pre-commit stage, which is the intended behavior for code quality checks in this repository's workflow.

Important Files Changed

Changed Files
Filename Score Overview
.pre-commit-config.yaml 5/5 Added explicit stage configuration to prevent duplicate ruff hook execution

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a simple, well-targeted fix that addresses a specific workflow inefficiency without affecting code functionality
  • No files require special attention

@dmarek-flex dmarek-flex self-assigned this Oct 15, 2025
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@mahlau-flex
Copy link
Contributor

I haven't noticed this, but probably just because I haven't paid close attention. Makes sense to fix this 👍

Copy link
Collaborator

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmarek-flex!

@yaugenst-flex yaugenst-flex added this pull request to the merge queue Oct 16, 2025
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants