Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to latest available version v1.58.2 #393

Merged
merged 1 commit into from
May 20, 2024
Merged

Update golangci-lint to latest available version v1.58.2 #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
container: golangci/golangci-lint:v1.58.0
container: golangci/golangci-lint:v1.58.2
steps:
- uses: actions/cache@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ GORUN=$(GOCMD) run
GOBUILD=$(GOCMD) build -v -ldflags $(LD_FLAGS) -trimpath

CC_TEST_REPORTER_ID=6e107e510c5479f40b0ce9166a254f3f1ee0bc547b3e48281bada1a5a32bb56d
GOLANGCI_LINT_VERSION=v1.58.0
GOLANGCI_LINT_VERSION=v1.58.2
BIN_PATH=$$HOME/bin

GO_PACKAGES=./...
Expand Down
4 changes: 3 additions & 1 deletion pkg/container/runtime/docker/docker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func TestNewClient(t *testing.T) {
// TODO does this kind of simple tests make sense? Integration tests calls the same thing
// anyway. Or maybe we should simply skip error checking in integration tests to simplify them?
c := &docker.Config{
//nolint:nilnil // Just test code.
ClientGetter: func(...client.Opt) (docker.Client, error) { return nil, nil },
}

Expand All @@ -54,6 +55,7 @@ func TestNewClientWithHost(t *testing.T) {
t.Log(k, v)
}

//nolint:nilnil // Just test code.
return nil, nil
},
}
Expand Down Expand Up @@ -95,7 +97,7 @@ func TestSanitizeImageName(t *testing.T) {
ImagePullF: func(context.Context, string, dockertypes.ImagePullOptions) (io.ReadCloser, error) {
t.Fatalf("Unexpected call to image pull")

return nil, nil
return nil, fmt.Errorf("unexpected call to image pull")
},
}, nil
},
Expand Down
Loading