Fixed bug with handling float entries with value 0 (#1369)

* Fixed bug with handling float entries with value 0 * Updated web dependencies
flow-php · Jan 14, 2025 · 57bdf56 · 57bdf56
1 parent ac75fbe
commit 57bdf56
Show file tree

Hide file tree

Showing 4 changed files with 143 additions and 194 deletions.
diff --git a/src/core/etl/src/Flow/ETL/Row/Entry/FloatEntry.php b/src/core/etl/src/Flow/ETL/Row/Entry/FloatEntry.php
@@ -35,7 +35,7 @@ public function __construct(private readonly string $name, ?float $value, public
             throw InvalidArgumentException::because('Precision must be greater or equal to 0 and less than 15');
         }
 
-        $this->value = $value ? round($value, $this->precision) : null;
+        $this->value = $value !== null ? round($value, $this->precision) : null;
         $this->type = type_float($this->value === null, $this->precision);
     }
 

diff --git a/src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/FloatEntryTest.php b/src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/FloatEntryTest.php
@@ -21,7 +21,7 @@ public static function is_equal_data_provider() : \Generator
         yield 'different names characters and different values with high precision' => [false, float_entry('NAME', 1.205502), float_entry('name', 1.205501)];
     }
 
-    public function test_accessing_precission() : void
+    public function test_accessing_precision() : void
     {
         self::assertSame(6, float_entry('name', 1.0)->precision);
         self::assertSame(3, float_entry('name', 1.0, 3)->precision);
@@ -30,6 +30,7 @@ public function test_accessing_precission() : void
     public function test_entry_name_can_be_zero() : void
     {
         self::assertSame('0', (float_entry('0', 0))->name());
+        self::assertSame(0.0, (float_entry('0', 0))->value());
     }
 
     #[DataProvider('is_equal_data_provider')]

diff --git a/web/landing/composer.json b/web/landing/composer.json
@@ -3,6 +3,7 @@
     "description": "Flow PHP ETL - Web",
     "type": "project",
     "require": {
+        "php": "8.2.*",
         "flow-php/etl": "1.x-dev",
         "flow-php/etl-adapter-http": "1.x-dev",
         "nyholm/psr7": "^1.8",
@@ -12,6 +13,7 @@
         "symfony/http-foundation": "^6.4",
         "symfony/routing": "^6.4",
         "symfony/framework-bundle": "^6.4",
+        "symfony/config": "^6.4",
         "symfony/twig-bundle": "^6.4",
         "symfony/asset-mapper": "^6.4",
         "symfony/asset": "^6.4",