Remove redundant transformer function eval (#1417)

* Remove redundant transformer function eval * Fix cs issues * Revert "Fix cs issues" This reverts commit 5798995. * Downgrade cs-fixer to 3.68.0 so Thrift isn't included * Dependabot should skip buggy [email protected]
flow-php · Jan 29, 2025 · d1ba94d · d1ba94d
1 parent f2a17fc
commit d1ba94d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -24,6 +24,9 @@ updates:
     directory: "/tools/cs-fixer"
     schedule:
       interval: "daily"
+    ignore:
+      - dependency-name: "friendsofphp/php-cs-fixer"
+        versions: ["3.68.3"]
 
   - package-ecosystem: "composer"
     directory: "/tools/infection"

diff --git a/src/core/etl/src/Flow/ETL/Transformer/ScalarFunctionTransformer.php b/src/core/etl/src/Flow/ETL/Transformer/ScalarFunctionTransformer.php
@@ -53,18 +53,16 @@ function (Row $r) use ($context) : Row {
                     return $r;
                 }
 
-                $val = $this->function->eval($r);
-
                 return $r->set(
                     $this->function instanceof ScalarFunction\TypedScalarFunction
                      ? $context->entryFactory()->createAs(
                          $this->entry instanceof Definition ? $this->entry->entry()->name() : $this->entry,
-                         $val,
+                         $value,
                          $this->function->returns()
                      )
                      : $context->entryFactory()->create(
                          $this->entry instanceof Definition ? $this->entry->entry()->name() : $this->entry,
-                         $val,
+                         $value,
                          $this->entry instanceof Definition ? $this->entry : null
                      )
                 );

diff --git a/tools/cs-fixer/composer.json b/tools/cs-fixer/composer.json
@@ -2,7 +2,7 @@
   "name": "flow-php/flow-tools",
   "description": "Flow PHP ETL - Tools",
   "require-dev": {
-    "friendsofphp/php-cs-fixer": "3.68.3"
+    "friendsofphp/php-cs-fixer": "3.68.0"
   },
   "config": {
     "allow-plugins": false

diff --git a/tools/cs-fixer/composer.lock b/tools/cs-fixer/composer.lock