-
-
Notifications
You must be signed in to change notification settings - Fork 44
Add After Last function with Tests #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
norberttech
merged 4 commits into
flow-php:1.x
from
f-lapinski:integration/symfony-string-after-last
Feb 27, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Flow\ETL\Function; | ||
|
||
use function Flow\ETL\DSL\{type_list, type_string}; | ||
use function Symfony\Component\String\u; | ||
use Flow\ETL\Function\ScalarFunction\TypedScalarFunction; | ||
use Flow\ETL\PHP\Type\Type; | ||
use Flow\ETL\Row; | ||
|
||
final class StringAfterLast extends ScalarFunctionChain implements TypedScalarFunction | ||
{ | ||
public function __construct( | ||
private readonly ScalarFunction|string $string, | ||
private readonly ScalarFunction|string $needle, | ||
private readonly ScalarFunction|bool $includeNeedle = false, | ||
) { | ||
} | ||
|
||
public function eval(Row $row) : mixed | ||
{ | ||
$string = (new Parameter($this->string))->asString($row); | ||
|
||
if ($string === null) { | ||
return null; | ||
} | ||
|
||
$needle = (new Parameter($this->needle))->as($row, type_string(), type_list(type_string())); | ||
$includeNeedle = (new Parameter($this->includeNeedle))->asBoolean($row); | ||
|
||
return u($string)->afterLast($needle, $includeNeedle)->toString(); | ||
} | ||
|
||
public function returns() : Type | ||
{ | ||
return type_string(); | ||
} | ||
} |
61 changes: 61 additions & 0 deletions
61
src/core/etl/tests/Flow/ETL/Tests/Unit/Function/StringAfterLastTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Flow\ETL\Tests\Unit\Function; | ||
|
||
use function Flow\ETL\DSL\row; | ||
use function Flow\ETL\DSL\{ref, str_entry, type_string}; | ||
use Flow\ETL\Function\{StringAfterLast}; | ||
use Flow\ETL\PHP\Type\Type; | ||
use Flow\ETL\Tests\FlowTestCase; | ||
|
||
final class StringAfterLastTest extends FlowTestCase | ||
{ | ||
public function test_returns_method_returns_string_type() : void | ||
{ | ||
$stringAfterFunction = new StringAfterLast('test', 'e'); | ||
$returnType = $stringAfterFunction->returns(); | ||
|
||
self::assertInstanceOf(Type::class, $returnType); | ||
|
||
self::assertTrue($returnType->isEqual(type_string())); | ||
} | ||
|
||
public function test_string_after_last() : void | ||
{ | ||
self::assertSame( | ||
'rld', | ||
ref('str')->stringAfterLast(ref('needle'))->eval( | ||
row( | ||
str_entry('str', 'hello world'), | ||
str_entry('needle', 'o') | ||
) | ||
) | ||
); | ||
} | ||
|
||
public function test_string_after_last_including_needle() : void | ||
{ | ||
self::assertSame( | ||
'orld', | ||
ref('str')->stringAfterLast(ref('needle'), includeNeedle: true)->eval( | ||
row( | ||
str_entry('str', 'hello world'), | ||
str_entry('needle', 'o') | ||
) | ||
) | ||
); | ||
} | ||
|
||
public function test_string_after_last_returns_null() : void | ||
{ | ||
self::assertNull( | ||
ref('str')->stringAfterLast('x')->eval( | ||
row( | ||
str_entry('str', null), | ||
) | ||
) | ||
); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.