Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper methods on Schema/Definition to manipulate metadata #1496

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

norberttech
Copy link
Member

Change Log

Added

  • helper methods on Schema/Definition to manipulate metadata

Fixed

Changed

  • Removed readonly from Schema Definition

Removed

Deprecated

Security


Description

@norberttech norberttech added the developer experience Resolving this issue should improve development experience for the library users. label Feb 23, 2025
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.813mb +0.00%  | 553.424ms -2.90% | ±0.82% -56.16% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.886mb +0.00%  | 1.066s +0.22%    | ±2.13% +34.72% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.334mb +0.00% | 901.889ms -3.35% | ±0.30% -47.03% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.543mb +0.00%  | 36.010ms -0.53%  | ±0.59% -32.98% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.518mb +0.00%  | 605.232ms -0.45% | ±0.69% +34.34% |
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.340mb +0.00% | 71.915ms -3.28% | ±1.53% -35.39% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.013mb +0.00%  | 103.764ms -3.80% | ±0.88% -57.82%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.360mb +0.00%  | 96.281ms -3.45%  | ±0.27% +260.01% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.204mb +0.00% | 20.672s -3.73%   | ±0.16% -85.59%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.010mb +0.00%  | 31.465ms -1.71%  | ±0.41% -32.09%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.983mb +0.00% | 463.433ms +0.89% | ±1.83% +249.64% |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.173mb +0.00%  | 233.013ms -2.84% | ±1.53% -31.14%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.695mb +0.00%  | 51.150ms -4.10%  | ±3.34% +231.64% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.883mb +0.00%  | 366.928ms -0.49% | ±1.40% -11.82%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.693mb +0.00%  | 72.912ms -2.10%  | ±1.97% +230.31% |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.026mb +0.00%  | 3.212ms -36.02%  | ±0.27% -92.61%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.313mb +0.00% | 186.133ms -0.99% | ±0.16% -43.89%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.033mb +0.00%  | 18.858ms -4.32%  | ±0.59% -60.70%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.901mb +0.00%  | 1.640ms -36.31%  | ±1.09% -68.73%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.901mb +0.00%  | 1.590ms -33.94%  | ±1.71% +65.99%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.062mb +0.00%  | 4.913ms -31.66%  | ±2.00% -17.04%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.591mb +0.00%  | 16.801ms -6.57%  | ±0.73% +28.30%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.591mb +0.00%  | 16.747ms -5.96%  | ±0.54% -34.58%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.282mb +0.00%  | 1.794μs -22.21%  | ±2.67% +32.08%  |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.282mb +0.00%  | 0.400μs -20.00%  | ±0.00% +0.00%   |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.500mb +0.00% | 14.857ms -18.54% | ±0.32% -0.13%   |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.567mb +0.00% | 74.817ms -7.46%  | ±0.55% +262.13% |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.110mb +0.00%  | 1.532ms -40.52%  | ±3.87% +26.12%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.413mb +0.00% | 65.173ms -4.76%  | ±0.22% -75.37%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.163mb +0.00%  | 3.863ms -32.13%  | ±2.06% -37.17%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.575mb +0.00%  | 41.935ms -14.50% | ±2.04% +304.43% |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.576mb +0.00%  | 42.344ms -14.57% | ±0.66% -18.18%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.575mb +0.00%  | 42.077ms -14.46% | ±1.19% +1.54%   |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.722mb +0.00%  | 8.235ms -14.32%  | ±0.58% +210.39% |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.472mb +0.00%  | 29.355ms -14.24% | ±0.84% +49.54%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.282mb +0.00%  | 13.842μs -21.47% | ±2.15% -34.64%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.282mb +0.00%  | 15.700μs -19.49% | ±1.04% -50.32%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.314mb +0.00% | 191.827ms -0.23% | ±0.98% +284.67% |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (48ec14a) to head (bc9763c).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1496   +/-   ##
=======================================
  Coverage   83.00%   83.01%           
=======================================
  Files         677      677           
  Lines       18079    18093   +14     
=======================================
+ Hits        15007    15020   +13     
- Misses       3072     3073    +1     
Components Coverage Δ
etl 86.00% <88.23%> (-0.01%) ⬇️
cli 86.73% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 76.75% <ø> (ø)
lib-parquet 84.33% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 91.16% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.19% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 88.08% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <100.00%> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit 93c0f52 into flow-php:1.x Feb 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Resolving this issue should improve development experience for the library users. size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant