-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny performance improvement on Path::partitions #919
Tiny performance improvement on Path::partitions #919
Conversation
Flow PHP - BenchmarksResults of the benchmarks from this PR are compared with the results from 1.x branch. Extractors+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench | bench_extract_10k | 1 | 3 | 35.131mb +0.00% | 709.078ms -7.28% | ±0.28% -74.26% |
| CSVExtractorBench | bench_extract_10k | 1 | 3 | 4.817mb +0.02% | 319.109ms -7.82% | ±0.71% +373.18% |
| JsonExtractorBench | bench_extract_10k | 1 | 3 | 4.881mb +0.02% | 943.743ms -4.00% | ±2.00% +26.96% |
| ParquetExtractorBench | bench_extract_10k | 1 | 3 | 239.585mb +0.00% | 1.164s +2.60% | ±0.69% +132.12% |
| TextExtractorBench | bench_extract_10k | 1 | 3 | 4.666mb +0.02% | 31.150ms -42.66% | ±0.79% +5.94% |
| XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.667mb +0.02% | 428.792ms -7.32% | ±0.67% +23.05% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 110.379mb +0.00% | 64.317ms +0.15% | ±0.58% -58.87% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench | bench_load_10k | 1 | 3 | 94.743mb +0.00% | 461.632ms +0.59% | ±0.30% -12.41% |
| CSVLoaderBench | bench_load_10k | 1 | 3 | 54.850mb +0.00% | 73.022ms +1.90% | ±0.71% +21.20% |
| JsonLoaderBench | bench_load_10k | 1 | 3 | 105.337mb +0.00% | 56.898ms +1.47% | ±0.42% -49.83% |
| ParquetLoaderBench | bench_load_10k | 1 | 3 | 320.547mb +0.00% | 1.299s +3.48% | ±1.07% +216.75% |
| TextLoaderBench | bench_load_10k | 1 | 3 | 17.707mb +0.00% | 42.239ms +4.65% | ±0.27% -5.65% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 115.995mb +0.00% | 397.905ms +2.49% | ±1.35% +420.84% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 59.713mb +0.00% | 200.406ms +2.66% | ±0.91% +157.07% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 14.839mb +0.00% | 41.602ms +1.05% | ±1.11% -15.70% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 59.401mb +0.00% | 330.590ms +1.35% | ±1.34% +252.57% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 14.325mb +0.00% | 65.206ms +0.04% | ±0.57% +7.82% |
| RowsBench | bench_chunk_10_on_10k | 2 | 3 | 76.460mb +0.00% | 3.513ms +9.96% | ±2.31% +86.10% |
| RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 96.253mb +0.00% | 187.182ms +0.98% | ±0.29% -74.54% |
| RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 74.778mb +0.00% | 18.568ms +0.46% | ±0.61% +206.69% |
| RowsBench | bench_drop_1k_on_10k | 2 | 3 | 77.700mb +0.00% | 1.771ms +8.34% | ±0.40% -71.74% |
| RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 77.700mb +0.00% | 1.667ms +2.01% | ±2.67% -7.86% |
| RowsBench | bench_entries_on_10k | 2 | 3 | 74.812mb +0.00% | 2.581ms +4.81% | ±2.03% +228.57% |
| RowsBench | bench_filter_on_10k | 2 | 3 | 75.341mb +0.00% | 14.687ms +1.06% | ±0.40% -61.40% |
| RowsBench | bench_find_on_10k | 2 | 3 | 75.341mb +0.00% | 14.705ms +1.29% | ±0.48% -44.43% |
| RowsBench | bench_find_one_on_10k | 10 | 3 | 73.244mb +0.00% | 1.794μs +11.70% | ±2.67% -7.55% |
| RowsBench | bench_first_on_10k | 10 | 3 | 73.244mb +0.00% | 0.400μs 0.00% | ±0.00% 0.00% |
| RowsBench | bench_flat_map_on_1k | 2 | 3 | 86.799mb +0.00% | 12.731ms +1.79% | ±0.41% +20.90% |
| RowsBench | bench_map_on_10k | 2 | 3 | 116.160mb +0.00% | 63.801ms +0.83% | ±1.02% -14.70% |
| RowsBench | bench_merge_1k_on_10k | 2 | 3 | 75.861mb +0.00% | 1.443ms +21.15% | ±2.63% +151.65% |
| RowsBench | bench_partition_by_on_10k | 2 | 3 | 79.207mb +0.00% | 59.196ms +1.83% | ±0.51% +66.65% |
| RowsBench | bench_remove_on_10k | 2 | 3 | 77.962mb +0.00% | 3.845ms -1.11% | ±2.13% +107.64% |
| RowsBench | bench_sort_asc_on_1k | 2 | 3 | 73.389mb +0.00% | 41.836ms +3.24% | ±2.50% +210.35% |
| RowsBench | bench_sort_by_on_1k | 2 | 3 | 73.390mb +0.00% | 42.043ms +3.42% | ±0.51% -66.36% |
| RowsBench | bench_sort_desc_on_1k | 2 | 3 | 73.389mb +0.00% | 41.950ms +2.60% | ±0.66% -45.21% |
| RowsBench | bench_sort_entries_on_1k | 2 | 3 | 75.686mb +0.00% | 7.403ms +0.81% | ±1.03% +705.31% |
| RowsBench | bench_sort_on_1k | 2 | 3 | 73.244mb +0.00% | 29.194ms +1.15% | ±1.02% +21.07% |
| RowsBench | bench_take_1k_on_10k | 10 | 3 | 73.244mb +0.00% | 13.341μs +1.84% | ±1.88% +51.21% |
| RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 73.244mb +0.00% | 15.835μs +0.22% | ±2.61% +152.85% |
| RowsBench | bench_unique_on_1k | 2 | 3 | 96.254mb +0.00% | 188.104ms -1.62% | ±0.81% -43.74% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
|
@@ -16,7 +16,7 @@ | |||
use Symfony\Component\Console\Output\OutputInterface; | |||
use Symfony\Component\Console\Style\SymfonyStyle; | |||
|
|||
if ('' !== \Phar::running(false)) { | |||
if ('' !== Phar::running(false)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I have no idea why CS Fixer is doing that but at this point I don't care, I spent way too much time trying to understand what/why cs fixer is doing something, it become extremely unstable recently, I might need to lock it to some specific version.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description