Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically cast datetime bulk entries into DateTime objects #929

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

norberttech
Copy link
Member

Change Log

Added

Fixed

  • Automatically cast datetime bulk entries into DateTime objects

Changed

Removed

Deprecated

Security


Description

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.238mb +0.00%  | 824.864ms +1.57% | ±1.21% +357.51% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.964mb +0.01%   | 341.466ms -0.24% | ±0.26% +7.17%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.107mb +0.01%   | 1.052s +0.69%    | ±0.29% -78.79%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.806mb +0.00% | 1.242s +0.37%    | ±0.51% -41.53%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.885mb +0.01%   | 34.847ms -2.14%  | ±1.23% -19.19%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.887mb +0.01%   | 429.600ms -1.55% | ±0.54% -68.66%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.587mb +0.00% | 64.150ms +0.21% | ±0.43% +702.49% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.618mb +0.00%  | 474.139ms -0.23% | ±0.51% -43.45%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.101mb +0.00%  | 71.950ms -1.68%  | ±0.42% -65.39%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.522mb +0.00% | 51.090ms -3.50%  | ±0.95% -5.19%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 321.728mb +0.00% | 1.295s -0.17%    | ±0.64% +278.43% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.925mb +0.00%  | 40.822ms -1.20%  | ±0.44% -76.93%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.688mb +0.00% | 488.874ms -1.27% | ±0.75% -38.26%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 60.166mb +0.00%  | 250.977ms +1.55% | ±0.93% -30.61%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 15.099mb +0.00%  | 53.175ms -0.68%  | ±0.20% -80.68%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.943mb +0.00%  | 435.667ms -0.87% | ±0.52% -62.52%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.482mb +0.00%  | 84.717ms -2.07%  | ±0.41% -57.64%  |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.662mb +0.00%  | 3.485ms -5.32%   | ±1.09% -52.45%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.388mb +0.00%  | 183.897ms +0.96% | ±0.92% -17.16%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.914mb +0.00%  | 18.230ms -0.11%  | ±1.17% -16.96%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.902mb +0.00%  | 1.700ms -3.05%   | ±1.61% +226.32% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.902mb +0.00%  | 1.659ms -6.79%   | ±0.96% -73.10%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 75.014mb +0.00%  | 2.697ms -3.16%   | ±0.28% -58.75%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.543mb +0.00%  | 14.360ms -16.85% | ±1.24% -37.99%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.543mb +0.00%  | 14.763ms -15.03% | ±1.87% +15.44%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.447mb +0.00%  | 1.906μs -4.98%   | ±2.44% +5.17%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.447mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 87.001mb +0.00%  | 13.012ms -12.27% | ±0.82% -46.02%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.362mb +0.00% | 63.890ms -2.28%  | ±1.31% -31.08%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 76.062mb +0.00%  | 1.235ms -19.53%  | ±1.26% +42.46%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 79.343mb +0.00%  | 57.504ms -3.09%  | ±0.50% +5.27%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 78.164mb +0.00%  | 3.953ms -4.89%   | ±3.07% -7.97%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.525mb +0.00%  | 38.789ms -5.84%  | ±1.23% -4.51%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.525mb +0.00%  | 40.051ms -3.46%  | ±0.83% -68.87%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.525mb +0.00%  | 39.780ms -2.05%  | ±0.42% -81.80%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.888mb +0.00%  | 7.442ms -0.87%   | ±0.97% -44.05%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.447mb +0.00%  | 28.642ms -6.05%  | ±0.45% -18.84%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.447mb +0.00%  | 13.743μs +3.00%  | ±2.38% -2.40%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.447mb +0.00%  | 16.400μs +2.83%  | ±0.50% -78.66%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.390mb +0.00%  | 183.471ms +1.03% | ±0.49% +223.10% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech force-pushed the feature/bulk-types branch 2 times, most recently from 2a75079 to 76eb701 Compare January 22, 2024 19:08
@norberttech norberttech merged commit 26f0d80 into flow-php:1.x Jan 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant