Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted fetching contributors logic to standalone service #959

Merged

Conversation

norberttech
Copy link
Member

@norberttech norberttech commented Feb 3, 2024

Change Log

Added

  • Using Flow cache when reading contributors and fallback to GitHub only when cache expires or does not exists

Fixed

Changed

  • Extracted fetching contributors logic to standalone service

Removed

Deprecated

Security


Description

@stloyd @owsiakl - please follow this convention of not putting logic into controllers.
The same rule applies to stimulus controllers, they should just coordinate services/components, not really hold any logic.

In case of twig, if there is anything repeatable (like classes) use {% set classes = [] %} and then {{ classes|join(' ') }}
For any other twig logic - please extract it to extensions.

@norberttech norberttech merged commit e1268ea into flow-php:1.x Feb 3, 2024
9 checks passed
@norberttech norberttech deleted the cleanup/landing-page-contributors branch December 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant