upgrade esbuild to 0.24 #553
Conversation
floydspace
commented
Sep 24, 2024
floydspace
commented
- migrate utils from fp-ts to effect
|
🎉 This PR is included in version 1.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| }, | ||
| "peerDependencies": { | ||
| "esbuild": ">=0.8 <0.24", |
There was a problem hiding this comment.
Is there any reason to be limited to 0.24? The 0.25 is already up and I rather have a more loose peerDependecy
There was a problem hiding this comment.
Hey @ebisbe
the reason is to avoid issues due to possible breaking changes coming from next versions. it already happened.
Peer version indicates that it is tested with this versions range and should work. But no one stops you to use the latest esbuild version - in this case package manager will scream of course, which is a reminder to you, that it becomes your problem, if something does not work.
And I accept PRs if the peer version needs to be updated, but only if it is properly tested.
There was a problem hiding this comment.
Thanks for the explanation. I ( wrongly ) assumed that they were using semversionig. I'll try to make a PR.
There was a problem hiding this comment.
I believe they are using semver, but semver for v0 means: minor increment can be a breaking change
