-
Notifications
You must be signed in to change notification settings - Fork 1.8k
in_elasticsearch: fixing missing config parameter description for http2. Fixes #11221. #11226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
in_elasticsearch: fixing missing config parameter description for http2. Fixes #11221. #11226
Conversation
Fixes fluent#11221. Signed-off-by: Eric D. Schabell <[email protected]>
WalkthroughThe change adds a descriptive string "Enable HTTP/2 support" to the HTTP/2 configuration option in the Elasticsearch input plugin's static config_map, replacing a NULL description. This improves the option's user-facing documentation without altering default values or runtime behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Added description text field to config option
http2for elasticsearch input pluginFixes: #11221
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Fixed in Docs PR: fluent/fluent-bit-docs#2246
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.