reload: fix hotreload when running on windows as service. #9908
+82
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwhelan
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
This should resolve #9824. |
edsiper
reviewed
Feb 4, 2025
| @@ -266,6 +267,8 @@ struct flb_config { | |||
| int enable_hot_reload; | |||
| int ensure_thread_safety_on_hot_reloading; | |||
| unsigned int hot_reloaded_count; | |||
| unsigned int hot_reloaded_failures_count; | |||
| volatile sig_atomic_t bin_restarting; | |||
There was a problem hiding this comment.
Originally this code was used to improve the reliability of the reload API so that it could be used in testing:
bin_restartingwas refactored out of thesrc/fluent-bit.cfile to expose it to the reload API to better track the reload state- hot_reloaded_failures_count was added to track failed reloads.
The hot_reloaded_failures_count is not crucial to this patch and can be removed.
There was a problem hiding this comment.
@edsiper should I drop hot_reloaded_failures_count and the relevant code?
…nfig. Signed-off-by: Phillip Whelan <[email protected]>
… windows. Signed-off-by: Phillip Whelan <[email protected]>
…load on windows. Signed-off-by: Phillip Whelan <[email protected]>
pwhelan
force-pushed
the
pwhelan-fix-hotreload-on-windows-as-service
branch
from
0e56dd0 to
1a99e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR involves several changes which allow both the API and fleet to reload on windows when running fluent-bit as a service.
Description
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.