Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector infers correct pub root directory for widget previews #8808

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

elliette
Copy link
Member

Fixes #8807

I'm assuming we never want to set a directory in .dart_tool as a pub root directory, but in case we do we can change the logic to specifically only exclude the widget_previews_scaffold directory.

@elliette elliette requested a review from a team as a code owner January 24, 2025 23:28
@elliette elliette requested review from bkonyi and kenzieschmoll and removed request for a team January 24, 2025 23:28
@elliette elliette changed the title Inspector infers correct pub root directory of widget previews Inspector infers correct pub root directory for widget previews Jan 24, 2025
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would build not be a better directory to look for if we have a running application?

Also, I'm not sure what the difference between the 'lib' / 'web' case and 'packages', but I assume there's a reason since that's just a refactor... :)

Overall, LGTM.

@elliette
Copy link
Member Author

Would build not be a better directory to look for if we have a running application?

Also, I'm not sure what the difference between the 'lib' / 'web' case and 'packages', but I assume there's a reason since that's just a refactor... :)

Overall, LGTM.

Possibly! But I don't want to change the existing logic (which currently works) unless there's a need to

@elliette elliette merged commit ea4aee5 into flutter:master Feb 10, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Widget Previews] Widget inspector hides widgets from user's local project in implementation widgets
2 participants