Use previous HTTP profile timestamps instead of DateTime.now() when requesting HTTP profiles#8860
Merged
auto-submit[bot] merged 8 commits intoflutter:masterfrom Feb 10, 2025
Conversation
…equesting HTTP profiles The time between the target process creating the HTTP profile and DevTools invoking DateTime.now() to set the last HTTP data refresh time could result in some HTTP events being missed. This change updates the network service to use the timestamp sent with the last HTTP profile when requesting the next HTTP profile so network latency won't introduce time gaps in the profile. This change also updates the logic to keep track of last HTTP profile request times by isolate as each profile has its own timestamp that needs to be used when requesting the next profile. Fixes flutter#8380 Fixes flutter#8305
This was referenced Feb 10, 2025
kenzieschmoll
approved these changes
Feb 10, 2025
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
a couple more comments then lgtm
…evtools into fix_network_profiler_time_since
kenzieschmoll
pushed a commit
that referenced
this pull request
Feb 12, 2025
…equesting HTTP profiles (#8860) The time between the target process creating the HTTP profile and DevTools invoking DateTime.now() to set the last HTTP data refresh time could result in some HTTP events being missed. This change updates the network service to use the timestamp sent with the last HTTP profile when requesting the next HTTP profile so network latency won't introduce time gaps in the profile. This change also updates the logic to keep track of last HTTP profile request times by isolate as each profile has its own timestamp that needs to be used when requesting the next profile. Fixes #8380 Fixes #8305
kenzieschmoll
pushed a commit
that referenced
this pull request
Feb 12, 2025
…equesting HTTP profiles (#8860) The time between the target process creating the HTTP profile and DevTools invoking DateTime.now() to set the last HTTP data refresh time could result in some HTTP events being missed. This change updates the network service to use the timestamp sent with the last HTTP profile when requesting the next HTTP profile so network latency won't introduce time gaps in the profile. This change also updates the logic to keep track of last HTTP profile request times by isolate as each profile has its own timestamp that needs to be used when requesting the next profile. Fixes #8380 Fixes #8305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time between the target process creating the HTTP profile and DevTools invoking DateTime.now() to set the last HTTP data refresh time could result in some HTTP events being missed. This change updates the network service to use the timestamp sent with the last HTTP profile when requesting the next HTTP profile so network latency won't introduce time gaps in the profile.
This change also updates the logic to keep track of last HTTP profile request times by isolate as each profile has its own timestamp that needs to be used when requesting the next profile.
Fixes #8380
Fixes #8305