Enable all bots on Windows #8864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Rebased, this is all green now) |
tool/ci/package_tests.sh
Outdated
|
|
||
| pushd $DEVTOOLS_DIR/packages/devtools_extensions | ||
| echo `pwd` | ||
| flutter test test/*_test.dart | ||
| flutter test test/web --platform chrome | ||
| # Skip this on Windows because `flutter test --platform chrome` | ||
| # appears to hand there. |
tool/ci/setup.sh
Outdated
| @@ -22,7 +21,6 @@ function flutter { | |||
| } | |||
| export -f flutter | |||
|
|
|||
| # TODO: Also support windows on github actions. | |||
| if [[ $RUNNER_OS == "Windows" ]]; then | |||
There was a problem hiding this comment.
is this if block necessary? It doesn't look like we manually install google chrome for the ubuntu OS. Looking at the comment, this is linking to an article from travis-ci, which we haven't used in 4 or 5 years.
There was a problem hiding this comment.
Good point - according to https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#browsers-and-drivers it's already installed, so this shouldn't be required. I've removed it - if the bots turn red I'll investigate.
Edit: it stayed green :-)
kenzieschmoll
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Windows bots on GitHub Actions by:
matrixto each bot that includeswindows-latest(note: the existing bots seem to mostly run on Linux includingdevtools-extensions-integration-testbutdevtools-app-integration-testruns on macOS and I'm not sure why the distinction... I added Windows both both anyway)shell: bashas a default so that the same scripts work on Windows bots (the GitHub runners do have a Bash version on Windows, but it's not the default shell)flutter.batwhen spawning Flutter on Windows (it would be nice to centralise this, but the tests are spread across different packages so I just left it inline for now)flutter test --platform chromefor devtools_extensions test because it seems broken (I've filedflutter test --platform chromehangs on "Loading x_test.dart" on Windows flutter#162798)This will slow down the bots on all PRs. We could reduce which ones run on Windows and/or only run them on a schedule, though these obviously remove some of the benefits of catching potential Windows issues earlier.
Note: There will still be some failures on this PR until #8846 is merged. I didn't include that in this PR to avoid confusing the review, but I will merge/rebase once that lands.(Rebased)