feat: Add file chooser support for widget preview initialization.#8888
feat: Add file chooser support for widget preview initialization.#8888helin24 merged 1 commit intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request enables users to specify the pub root module for the Flutter Widget Previewer by adding a file selection dialog and a retry mechanism when the root is not automatically detected. Review feedback highlights the need to wrap file system and project index access within Read Actions to comply with IntelliJ threading requirements and suggests externalizing user-facing strings for localization.
ad4855d to
35ebf75
Compare
|
Fantastic! Since Helin wrote this, I'll defer to her for a review when she's back from vacation. |
helin24
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution.
Can you add a screenshot of the file choosing dialog?
When using a multi-module project, the widget previewer sometimes fails to automatically find the correct pubspec.yaml. Adding the possibility to manually choose the file allows for more complex project setups.
|
Sure! I've added your suggested change and added a screenshot of the file chooser dialog to the PR description. |
|
Thanks @nopjar! |
When using a multi-module project, the widget previewer sometimes fails to automatically find the correct pubspec.yaml. Adding the possibility to manually choose the file allows for more complex project setups.
Review the contribution guidelines below:
AUTHORSfile.CHANGELOG.mdif appropriate.Contribution guidelines:
our contributor guide and
the Flutter organization contributor guide
for general expectations for PRs.
dart format.practices (discussion).