web-fixes #85
Open
web-fixes #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal_asset_for_picture_marker_symbol # Conflicts: # arcgis_map_sdk_android/android/src/main/kotlin/dev/fluttercommunity/arcgis_map_sdk_android/ArcgisMapView.kt
…cal_asset_for_picture_marker_symbol
…res_iteration_4-5 # Conflicts: # arcgis_map_sdk/lib/src/arcgis_map_controller.dart # arcgis_map_sdk_ios/ios/Classes/ArcgisMapView.swift
…ion-indicator' into all_features_iteration_4-5 # Conflicts: # arcgis_map_sdk/lib/src/arcgis_map_controller.dart # arcgis_map_sdk_android/android/src/main/kotlin/dev/fluttercommunity/arcgis_map_sdk_android/ArcgisMapView.kt # arcgis_map_sdk_ios/ios/Classes/ArcgisMapView.swift
# Conflicts: # arcgis_map_sdk_android/android/src/main/kotlin/dev/fluttercommunity/arcgis_map_sdk_android/ArcgisMapView.kt # arcgis_map_sdk_ios/ios/Classes/ArcgisMapView.swift
# Conflicts: # arcgis_map_sdk/README.md # arcgis_map_sdk_android/android/src/main/kotlin/dev/fluttercommunity/arcgis_map_sdk_android/ArcgisMapView.kt # arcgis_map_sdk_ios/ios/Classes/ArcgisMapView.swift
TarekTolba1
reviewed
Mar 13, 2025
| @@ -828,6 +829,50 @@ class LayerController { | |||
| return zoom >= minZoom && zoom <= maxZoom; | |||
| } | |||
|
|
|||
| Future<void> moveCameraToPoints({ | |||
| required List<LatLng> points, | |||
| double? padding, | |||
There was a problem hiding this comment.
I assume padding won’t be supported on the web?
TarekTolba1
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a Bug where the web arcgis controller threw an exception due to a missing override.
setMethodCallHandlerIt also implements
moveCameraToPointsfor web which was previously only available for android and iOS