Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skipDoubleRegistration with instanceName #380

Conversation

KnightOfBlackLily
Copy link
Contributor

Fix for skipDoubleRegistration behavior

Description

This PR fixes the behavior of the skipDoubleRegistration parameter. Previously, it ignored registration regardless of the instanceName value. Now, registration is only skipped if the instanceName matches, which is the expected behavior.

Changes made:

  • Updated the logic for skipDoubleRegistration to take instanceName into account when deciding whether to skip registration.

Why this is important:

This fix prevents situations where a registration could be mistakenly skipped even with different instanceName values, which caused incorrect behavior in certain scenarios.

Testing:

  • Tested with both unnamed registrations and those with instanceName values to ensure that registration is only skipped when names are the same and works as expected otherwise.

@escamoteur
Copy link
Collaborator

Nice catch

@escamoteur escamoteur merged commit e52b9ff into fluttercommunity:master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants