fix: skipDoubleRegistration with instanceName #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
skipDoubleRegistration
behaviorDescription
This PR fixes the behavior of the
skipDoubleRegistration
parameter. Previously, it ignored registration regardless of theinstanceName
value. Now, registration is only skipped if theinstanceName
matches, which is the expected behavior.Changes made:
skipDoubleRegistration
to takeinstanceName
into account when deciding whether to skip registration.Why this is important:
This fix prevents situations where a registration could be mistakenly skipped even with different
instanceName
values, which caused incorrect behavior in certain scenarios.Testing:
instanceName
values to ensure that registration is only skipped when names are the same and works as expected otherwise.