fix(share_plus) sharing content on huawei or honor vendor which changed the default intent of Intent.ACTION_SEND

[OnClickListener2048]

fix(share_plus) sharing content on huawei or honor vendor which changed the default intent of Intent.ACTION_SEND

Description

for those OEM vendor brand that changed default choose intent of Intent.ACTION_SEND, I fixed Huawei and Honor vendor share intent

Related Issues

• Related [Question]: Huawei and Honor models, can the text in the middle of the pop-up window be modified? #3186
• Related 分享pdf文件 #1588
• Related [Question]: I'm using share_plus to share on Android and the UI is inconsistent with other apps. #1030

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I titled the PR using Conventional Commits.
• I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
• All existing and new tests are passing.
• The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
• No, this is not a breaking change.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix(share_plus) sharing content on huawei or honor vendor which changed the default intent of Intent.ACTION_SEND". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[miquelbeltran]

Hello, I took a quick look, overall I understand why would you need this in the share_plus, but I have some concerns:

• Are com.huawei.android.internal.app and com.huawei.intent.action.hwCHOOSER documented somewhere? Is there an API spec somewhere? My biggest issue is that this seems like a hack, plus no one in the maintainer team has a device from those manufacturers, so we don't have a way to maintain this.
• getAvailableOemChooser runs every time a share action is done, and instead it should be optional, and IMO the option disabled by default.
• The change wouldn't be compatible with the refactor in progress, but that's not a big problem: feat(share_plus)!: SharePlus refactor #3404

I'd prefer if we could make setting the intent action as a share parameter, or even the "package-name - intent" pairs something that can be passed as a parameter (following the changes in #3404) so at least we can give the option for those devs that want to target the custom share sheets from the different manufacturers.

[OnClickListener2048]

Hello, I took a quick look, overall I understand why would you need this in the share_plus, but I have some concerns:

• Are com.huawei.android.internal.app and com.huawei.intent.action.hwCHOOSER documented somewhere? Is there an API spec somewhere? My biggest issue is that this seems like a hack, plus no one in the maintainer team has a device from those manufacturers, so we don't have a way to maintain this.
• getAvailableOemChooser runs every time a share action is done, and instead it should be optional, and IMO the option disabled by default.
• The change wouldn't be compatible with the refactor in progress, but that's not a big problem: feat(share_plus): SharePlus refactor #3404

I'd prefer if we could make setting the intent action as a share parameter, or even the "package-name - intent" pairs something that can be passed as a parameter (following the changes in #3404) so at least we can give the option for those devs that want to target the custom share sheets from the different manufacturers.

Thank you for your fine response for my last pr and i realized this change would be unfair for other kind system and the right way is passing paramaters for those OES OS, but i think the problem is really exist and does effect some developers especially in China,so do you think i just edit this pr or i should close this pr and reopen a new one after i repair this ?

[miquelbeltran]

I will close this PR for the time being. If you can, write a proposal on a new ticket, and it should be implemented over the refactor in #3404