kvs: remove dropcache #6622
Open
kvs: remove dropcache #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: KVS dropcache code was added very early on in KVS prototyping for testing. It is basically not used anymore. If we want to test something that requires a "clean" slate for the KVS, we can just start a new instance and test with that. Solution: Remove all KVS dropcache code. Remove all associated tests. Update one regression test to be accomplished through two instances rather than one to emulate an emptying of the cache. Fixes flux-framework#6608
|
one builder failed with |
Problem: The kvs.dropcache RPC target no longer exists, yet the "flux kvs dropcache" command still exists. Remove "flux kvs dropcache" support.
Problem: The flux kvs dropcache command has been removed, but is still documented. Remove "dropcache" from flux-kvs(1).
Problem: The kvs.dropcache RPC target has been removed, but the library function flux_kvs_dropcache() still exists. Remove flux_kvs_dropcache() from libkvs.
Problem: The flux kvs dropcache command has been removed, but bash completions still exist for it. Remove bash completions for flux kvs dropcache.
Problem: The flux_kvs_dropcache() API function has been removed, but Python still has a binding to it. Remove the kvs dropcache() function.
|
OMG, I'm so stupid. I forgot that there was a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6622 +/- ##
==========================================
- Coverage 83.86% 83.84% -0.02%
==========================================
Files 534 534
Lines 88358 88305 -53
==========================================
- Hits 74100 74043 -57
- Misses 14258 14262 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: KVS dropcache code was added very early on in KVS prototyping for testing. It is basically not used anymore. If we want to test something that requires a "clean" slate for the KVS, we can just start a new instance and test with that.
Solution: Remove all KVS dropcache code. Remove all associated tests. Update one regression test to be accomplished through two instances rather than one to emulate an emptying of the cache.
Fixes #6608