Adding tests for accept function in the filter package #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
reviewed
Feb 1, 2024
|
Please rebase with upstream main and force push, this PR should have a single commit before we can merge it. Thanks |
Bumps the ci group with 2 updates: [korthout/backport-action](https://github.com/korthout/backport-action) and [anchore/sbom-action](https://github.com/anchore/sbom-action). Updates `korthout/backport-action` from 2.4.0 to 2.4.1 - [Release notes](https://github.com/korthout/backport-action/releases) - [Commits](korthout/backport-action@79b9f24...e8161d6) Updates `anchore/sbom-action` from 0.15.5 to 0.15.6 - [Release notes](https://github.com/anchore/sbom-action/releases) - [Commits](anchore/sbom-action@24b0d52...c6aed38) --- updated-dependencies: - dependency-name: korthout/backport-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ci - dependency-name: anchore/sbom-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ci ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the ci group with 3 updates: [docker/metadata-action](https://github.com/docker/metadata-action), [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) and [anchore/sbom-action](https://github.com/anchore/sbom-action). Updates `docker/metadata-action` from 5.5.0 to 5.5.1 - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@dbef880...8e5442c) Updates `sigstore/cosign-installer` from 3.3.0 to 3.4.0 - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@9614fae...e1523de) Updates `anchore/sbom-action` from 0.15.6 to 0.15.8 - [Release notes](https://github.com/anchore/sbom-action/releases) - [Commits](anchore/sbom-action@c6aed38...b6a39da) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ci - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ci - dependency-name: anchore/sbom-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ci ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
Signed-off-by: zhaque44 <[email protected]>
zhaque44
force-pushed
the
update-filter
branch
from
9e7dca4 to
c594b4a
Compare
ive made an error, im opening a new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for Accept - Scalar Node:
Description: Tests the accept function when provided with a scalar node and valid setter schema.
The function should not return an error (assert.NoError).
The expected error value should be false (assert.Equal).
Tests for Accept - Scalar Node - Error:
Description: Tests the accept function when provided with a scalar node, with invalid setter schema.
The function should not return an error (assert.NoError).
The expected error value should be true (assert.Equal).