Adding assertions for AddChange test scenario for ResultV2 Test #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaque44 <[email protected]>
|
Hi @souleb hope you are doing well, I made the necessary changes recommended here: #682 (comment) please review this when you have a minute |
|
@souleb hey can you take a look at these changes please |
stefanprodan
reviewed
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated test accounts for much needed assertions for AddChange scenario in Result V2 test:
This code snippet initializes an expectedFileChanges variable, which is containing the expected changes. Each file is associated with a set of object changes represented by ObjectChanges. Within each file's changes, specific objects are associated with an array of Change structs, where each struct represents a change in values. The g.Expect(result.FileChanges) statement asserts that the FileChanges field of the result variable matches the expected changes defined.