Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional values for commit message template #772

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

bigkevmcd
Copy link
Contributor

Fixes: #679

This adds .spec.git.commit.messageTemplateValues as a map of strings that can be used to supplement the rendering of the commit message template.

@bigkevmcd bigkevmcd force-pushed the message-template-values branch from 215893c to ba877df Compare October 21, 2024 17:54
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this field to the API docs along with an example

@bigkevmcd bigkevmcd force-pushed the message-template-values branch from fa5cbbe to e10cfe0 Compare October 22, 2024 19:08
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @bigkevmcd 🥇

@stefanprodan stefanprodan added enhancement New feature or request area/api API related issues and pull requests labels Oct 22, 2024
This adds .spec.git.commit.messageTemplateValues as a map of strings
that can be used to supplement the rendering of the commit message
template.

Signed-off-by: Kevin McDermott <[email protected]>
Signed-off-by: Kevin McDermott <[email protected]>
@bigkevmcd bigkevmcd force-pushed the message-template-values branch from 135fe06 to 189ba58 Compare October 28, 2024 10:38
@stefanprodan stefanprodan merged commit ebeead0 into fluxcd:main Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API related issues and pull requests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: A dictionary of values for the commit message template
3 participants