Skip to content

feat(framework): Add startup update checks for SuperLink, SuperNode, and SuperExec#6786

Merged
danieljanes merged 29 commits intomainfrom
add-update-check-to-superlink-supernode-superexec
Mar 23, 2026
Merged

feat(framework): Add startup update checks for SuperLink, SuperNode, and SuperExec#6786
danieljanes merged 29 commits intomainfrom
add-update-check-to-superlink-supernode-superexec

Conversation

@mohammadnaseri
Copy link
Member

This PR introduces a shared startup-only update check for flower-superlink, flower-supernode, and flower-superexec.

Copilot AI review requested due to automatic review settings March 18, 2026 10:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a shared “startup-only” Flower version update check and wires it into the flower-superlink, flower-supernode, and flower-superexec CLIs so users can be warned when they’re running an outdated runtime.

Changes:

  • Introduces warn_if_flwr_update_available (and payload helpers/constants) in flwr.supercore.utils.
  • Calls the update check during startup for SuperLink, SuperNode, and SuperExec.
  • Adds unit tests validating the update-check behavior and request payload.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
framework/py/flwr/supernode/cli/flower_supernode.py Invokes update check during SuperNode startup.
framework/py/flwr/supernode/cli/flower_supernode_test.py Tests that SuperNode runs the update check after parsing args.
framework/py/flwr/supercore/utils.py Implements update-check payload creation + HTTP call + opt-out env var.
framework/py/flwr/supercore/utils_test.py Adds tests for payload composition, opt-out behavior, request parameters, and failure modes.
framework/py/flwr/supercore/cli/flower_superexec.py Invokes update check during SuperExec startup.
framework/py/flwr/supercore/cli/flower_superexec_test.py Tests that SuperExec runs the update check after parsing args.
framework/py/flwr/server/app.py Invokes update check during SuperLink startup.
framework/py/flwr/server/app_test.py Tests that SuperLink runs the update check after parsing args.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions github-actions bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Mar 18, 2026
panh99 added 3 commits March 19, 2026 21:58
…ithub.com:flwrlabs/flower into add-update-check-to-superlink-supernode-superexec
This reverts commit 324b64b.
Co-authored-by: Heng Pan <pan@flower.ai>
Copy link
Member

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieljanes danieljanes merged commit f2c0e27 into main Mar 23, 2026
130 of 131 checks passed
@danieljanes danieljanes deleted the add-update-check-to-superlink-supernode-superexec branch March 23, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers. new version check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants